Skip to content

Polish #42798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Polish #42798

wants to merge 2 commits into from

Conversation

ngocnhan-tran1996
Copy link
Contributor

This PR includes

  • Simplify ternary operator condition. I think the method can return direct result instead
  • Use String#isEmpty instead String#equals("")
  • Polish diamond operator usage

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 19, 2024
@philwebb philwebb added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 20, 2024
@philwebb philwebb modified the milestones: 3.3.x, 3.4.x Oct 20, 2024
@mhalbritter mhalbritter self-assigned this Oct 21, 2024
mhalbritter pushed a commit that referenced this pull request Oct 21, 2024
@ngocnhan-tran1996 @mhalbritter
Polish
fcbf6b0 
See gh-42798
@mhalbritter
Copy link
Contributor

Thanks @ngocnhan-tran1996 !

@mhalbritter mhalbritter modified the milestones: 3.4.x, 3.4.0-RC1 Oct 21, 2024
@ngocnhan-tran1996 ngocnhan-tran1996 deleted the improve-code branch October 23, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mhalbritter mhalbritter

Labels
type: task A general task
Projects
None yet
Milestone
3.4.0-RC1
Development

Successfully merging this pull request may close these issues.
4 participants
@ngocnhan-tran1996 @mhalbritter @philwebb @spring-projects-issues